Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let provider instances Uri return actual instance DTSTART and DUE rather than the master task values #615

Closed
dmfs opened this issue Jan 7, 2018 · 1 comment
Closed

Let provider instances Uri return actual instance DTSTART and DUE rather than the master task values #615

dmfs opened this issue Jan 7, 2018 · 1 comment
Labels
provider

Comments

@dmfs
Copy link
Owner

dmfs commented Jan 7, 2018 •
edited
Loading

Currently, the instances view contains the joined task data as is. When returning the values to the UI it's probably easier if we emulate overrides even for non-overridden recurring instances, which means the task data should contain the actual instance DTSTART and DUE values instead of the ones of the master task.
@dmfs dmfs added the provider label Jan 7, 2018
dmfs added a commit that referenced this issue Jan 8, 2018
@dmfs
Let instance view return instance DTSTART and DUE rather than the tas…
cc65c79 
…k values. Implements #615

This commit improves the instances view by returning the instance start and due times as task `DTSTART` and `DUE`. This way the UI will see the correct instance times.

From the UI perspective the instances view is now a list of individual non-recurring instances, which can be read and written on its own.

Note, for non-recurring tasks, this won't have any effect.
@dmfs dmfs mentioned this issue Jan 8, 2018
Merged
dmfs added a commit that referenced this issue Jan 9, 2018
@dmfs
Let instance view return instance DTSTART and DUE rather than the tas…
76dbaa7 
…k values. Implements #615 (#620)

This commit improves the instances view by returning the instance start and due times as task `DTSTART` and `DUE`. This way the UI will see the correct instance times.

From the UI perspective the instances view is now a list of individual non-recurring instances, which can be read and written on its own.

Note, for non-recurring tasks, this won't have any effect.

This also changes INSTANCE_ORIGINAL_TIME to use null for non-recurring tasks.
dmfs added a commit that referenced this issue Sep 30, 2018
@dmfs
Let instance view return instance DTSTART and DUE rather than the tas…
ccfad69 
…k values. Implements #615

This commit improves the instances view by returning the instance start and due times as task `DTSTART` and `DUE`. This way the UI will see the correct instance times.

From the UI perspective the instances view is now a list of individual non-recurring instances, which can be read and written on its own.

Note, for non-recurring tasks, this won't have any effect.
@dmfs
Copy link
Owner Author

dmfs commented Jan 18, 2019

Done,

@dmfs dmfs closed this as completed Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
provider
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmfs