Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store non-recurring tasks with INSTANCE_ORIGINAL_TIME=0 #577

Closed
dmfs opened this issue Dec 13, 2017 · 0 comments
Closed

Store non-recurring tasks with INSTANCE_ORIGINAL_TIME=0 #577

dmfs opened this issue Dec 13, 2017 · 0 comments
Labels
enhancement provider

Comments

@dmfs
Copy link
Owner

dmfs commented Dec 13, 2017

Non-recurring tasks can't have overridden instances, so the INSTANCE_ORIGINAL_TIME of these tasks is never being used. If we store 0 instead of the start or due time we can ensure that the instance id of non-recurring tasks is always stable.
@dmfs dmfs changed the title Store non-recurring tasks with INSTANCE_ORIGINAL_TIME =0 Store non-recurring tasks with INSTANCE_ORIGINAL_TIME=0 Dec 13, 2017
dmfs added a commit that referenced this issue Dec 13, 2017
@dmfs
Make sure non-recurring tasks get an INSTANCE_ORIGINAL_TIME of 0. Imp…
1ef85c5 
…lements #577

This resulted in a minor SRP-ish refactoring to separate steps of instance value creation.
@dmfs dmfs mentioned this issue Dec 13, 2017
Merged
dmfs added a commit that referenced this issue Dec 20, 2017
@dmfs
Make sure non-recurring tasks get an INSTANCE_ORIGINAL_TIME of 0. Imp…
d8fa2d8 
…lements #577 (#581)

This resulted in a minor SRP-ish refactoring to separate steps of instance value creation.
@dmfs dmfs closed this as completed Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement provider
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmfs