Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllegalArgumentExceptions on Google Play #507

Closed
dmfs opened this issue Nov 25, 2017 · 6 comments
Closed

IllegalArgumentExceptions on Google Play #507

dmfs opened this issue Nov 25, 2017 · 6 comments
Assignees
Milestone

Comments

@dmfs
Copy link
Owner

dmfs commented Nov 25, 2017

This is a stack trace reported on Google Play by several users

java.lang.RuntimeException: 
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:3636)
  at android.app.ActivityThread.handleResumeActivity (ActivityThread.java:3676)
  at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:2876) 
  at android.app.ActivityThread.-wrap12 (ActivityThread.java)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1567)
  at android.os.Handler.dispatchMessage (Handler.java:105)
  at android.os.Looper.loop (Looper.java:156)
  at android.app.ActivityThread.main (ActivityThread.java:6577)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:942)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:832)
Caused by: java.lang.IllegalArgumentException: 
  at org.dmfs.tasks.EditTaskActivity.onAttachFragment (EditTaskActivity.java:178)
  at android.support.v4.app.FragmentActivity$HostCallbacks.onAttachFragment (FragmentActivity.java:1083)
  at android.support.v4.app.FragmentManagerImpl.moveToState (FragmentManager.java:1054)
  at android.support.v4.app.BackStackRecord.setLastIn (BackStackRecord.java:838)
  at android.support.v4.app.BackStackRecord.calculateFragments (BackStackRecord.java:861)
  at android.support.v4.app.BackStackRecord.run (BackStackRecord.java:719)
  at android.support.v4.app.FragmentManagerImpl.execPendingActions (FragmentManager.java:1682)
  at android.support.v4.app.FragmentController.execPendingActions (FragmentController.java:388)
  at android.support.v4.app.FragmentActivity.onPostResume (FragmentActivity.java:499)
  at android.support.v7.app.AppCompatActivity.onPostResume (AppCompatActivity.java:175)
  at android.app.Activity.performResume (Activity.java:7043)
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:3611)
@dmfs dmfs added this to the 1.1.11 milestone Nov 25, 2017
@dmfs
Copy link
Owner Author

dmfs commented Nov 25, 2017

@lemonboston could this be caused by attaching the PermissionRequestDialogFragment in the editor? If so, this probably can happen only when clicking the plus on the widget, otherwise the permission should have been granted already on the list view.

@dmfs
Copy link
Owner Author

dmfs commented Nov 25, 2017

I can indeed reproduce this when clicking on the widget "+" button before granting the permission.

@lemonboston
Copy link
Contributor

For me when I am adding the widget to home screen, our permission dialog comes up which is not dismissible.
Could you please write down step-by-step how to reproduce it?

@dmfs
Copy link
Owner Author

dmfs commented Nov 27, 2017

Add the widget with the previous version.

@dmfs
Copy link
Owner Author

dmfs commented Nov 27, 2017

Optionally just revoke the permission after creating the widget.

@lemonboston lemonboston self-assigned this Nov 28, 2017
lemonboston pushed a commit that referenced this issue Nov 28, 2017
@lemonboston
Copy link
Contributor

I could reproduce it, fix is coming shortly.

Dumping the cause message of the exception:

Caused by: java.lang.IllegalArgumentException: Invalid fragment attached: org.dmfs.tasks.utils.permission.dialog.PermissionRequestDialogFragment
                                                                  at org.dmfs.tasks.EditTaskActivity.onAttachFragment(EditTaskActivity.java:178)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants