Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notification on changes #400

Closed
noresistence opened this issue Aug 3, 2017 · 1 comment
Closed

Update notification on changes #400

noresistence opened this issue Aug 3, 2017 · 1 comment

Comments

@noresistence
Copy link

Notifications don't get updated, when the corresponding task is changed.

Reproduction

Add a task that is due today. A notification appears. Now do not click on the notification. from the tasks app:

  1. change title
  2. change the due date to tomorrow
  3. delete the task

Expected behaviour

  1. Notification changes title
  2. Notification disappears
  3. Notification disappears

Observed behaviour

Notification does not change at all.
dmfs added a commit that referenced this issue Jun 12, 2019
@dmfs
Update notifications, implements #400
fd5490e 
When a task is modified we compare the current notification state to the new one and update the notification if necessary.

In certain cases we remove the notification now:

* the task was unpinned (by the sync adapter)
* the start of a task has been postponed
* the due date of a task has been postponed
* a task has been completed
dmfs added a commit that referenced this issue Jun 12, 2019
@dmfs
Update notifications, implements #400 (#809)
a097413 
When a task is modified we compare the current notification state to the new one and update the notification if necessary.

In certain cases we remove the notification now:

* the task was unpinned (by the sync adapter)
* the start of a task has been postponed
* the due date of a task has been postponed
* a task has been completed
@dmfs
Copy link
Owner

dmfs commented Jun 12, 2019

updating/removing notifications is now implemented

@dmfs dmfs closed this as completed Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmfs @noresistence