Notify about stale lists, fixes #917 (#924)

Use an important notification to inform the user about a stale list rather than launching an activity from the background.
dmfs · Mar 20, 2020 · d7f08ff · d7f08ff
1 parent 8ddf52d
commit d7f08ff
Showing 1 changed file with 40 additions and 6 deletions.
diff --git a/opentasks/src/main/java/org/dmfs/tasks/StaleListBroadcastReceiver.java b/opentasks/src/main/java/org/dmfs/tasks/StaleListBroadcastReceiver.java
@@ -18,11 +18,17 @@
 
 import android.accounts.Account;
 import android.accounts.AccountManager;
+import android.app.Notification;
+import android.app.NotificationChannel;
+import android.app.NotificationManager;
+import android.app.PendingIntent;
 import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.Intent;
+import android.content.res.Resources;
 import android.os.Build;
 
+import org.dmfs.android.bolts.color.colors.AttributeColor;
 import org.dmfs.android.contentpal.RowDataSnapshot;
 import org.dmfs.android.contentpal.RowSnapshot;
 import org.dmfs.android.contentpal.predicates.AccountEq;
@@ -31,12 +37,13 @@
 import org.dmfs.android.contentpal.predicates.Not;
 import org.dmfs.android.contentpal.projections.MultiProjection;
 import org.dmfs.android.contentpal.rowsets.QueryRowSet;
-import org.dmfs.iterables.elementary.Seq;
 import org.dmfs.jems.iterable.composite.Joined;
 import org.dmfs.jems.iterable.decorators.Mapped;
+import org.dmfs.jems.iterable.elementary.Seq;
 import org.dmfs.opentaskspal.views.TaskListsView;
 import org.dmfs.provider.tasks.AuthorityUtil;
 import org.dmfs.tasks.contract.TaskContract;
+import org.dmfs.tasks.utils.ManifestAppName;
 
 import java.util.ArrayList;
 
@@ -58,25 +65,52 @@ public void onReceive(Context context, Intent intent)
         }
         AccountManager accountManager = AccountManager.get(context);
         String authority = AuthorityUtil.taskAuthority(context);
-        String description = String.format("Please give %s access to the following account", context.getString(R.string.app_name));
+        String description = String.format("Please give %s access to the following account", new ManifestAppName(context).value());
         // request access to each account we don't know yet individually
         for (Intent accountRequestIntent :
                 new Mapped<>(
                         account -> AccountManager.newChooseAccountIntent(account, new ArrayList<Account>(singletonList(account)), null,
                                 description, null,
                                 null, null),
-                        new Mapped<RowDataSnapshot<TaskContract.TaskLists>, Account>(
+                        new Mapped<>(
                                 this::account,
                                 new Mapped<>(RowSnapshot::values,
                                         new QueryRowSet<>(
                                                 new TaskListsView(authority, context.getContentResolver().acquireContentProviderClient(authority)),
                                                 new MultiProjection<>(TaskContract.TaskLists.ACCOUNT_NAME, TaskContract.TaskLists.ACCOUNT_TYPE),
                                                 new Not<>(new AnyOf<>(
-                                                        new Joined<>(new Seq<>(
-                                                                new EqArg<>(TaskContract.TaskLists.ACCOUNT_TYPE, TaskContract.LOCAL_ACCOUNT_TYPE)),
+                                                        new Joined<>(
+                                                                new Seq<>(new EqArg<>(TaskContract.TaskLists.ACCOUNT_TYPE, TaskContract.LOCAL_ACCOUNT_TYPE)),
                                                                 new Mapped<>(AccountEq::new, new Seq<>(accountManager.getAccounts()))))))))))
         {
-            context.startActivity(accountRequestIntent);
+            if (Build.VERSION.SDK_INT < 28)
+            {
+                context.startActivity(accountRequestIntent);
+            }
+            else
+            {
+                // on newer Android versions post a notification instead because we can't launch activities from the background anymore
+                String notificationDescription = String.format("%s needs your permission", new ManifestAppName(context).value());
+                NotificationManager nm = context.getSystemService(NotificationManager.class);
+                if (nm != null)
+                {
+                    NotificationChannel errorChannel = new NotificationChannel("provider_messages", "Sync Messages", NotificationManager.IMPORTANCE_HIGH);
+                    nm.createNotificationChannel(errorChannel);
+                    Resources.Theme theme = context.getTheme();
+                    theme.applyStyle(context.getApplicationInfo().theme, true);
+
+                    nm.notify("stale_list_broadacast", 0,
+                            new Notification.Builder(context, "provider_messages")
+                                    .setContentText(notificationDescription)
+                                    .setContentIntent(PendingIntent.getActivity(context, 0, accountRequestIntent, PendingIntent.FLAG_UPDATE_CURRENT))
+                                    .addAction(new Notification.Action.Builder(null, "Grant",
+                                            PendingIntent.getActivity(context, 0, accountRequestIntent, PendingIntent.FLAG_UPDATE_CURRENT)).build())
+                                    .setColor(new AttributeColor(theme, R.attr.colorPrimary).argb())
+                                    .setColorized(true)
+                                    .setSmallIcon(R.drawable.ic_24_opentasks)
+                                    .build());
+                }
+            }
         }
     }