Fix ViewPager-TabLayout bug about loosing the tab icons. #643

dmfs · Jan 26, 2018 · c328d56 · c328d56
1 parent e39302a
commit c328d56
Showing 1 changed file with 15 additions and 7 deletions.
diff --git a/opentasks/src/main/java/org/dmfs/tasks/TaskListActivity.java b/opentasks/src/main/java/org/dmfs/tasks/TaskListActivity.java
@@ -267,12 +267,7 @@ protected void onCreate(Bundle savedInstanceState)
         // Bind the tabs to the ViewPager
         mTabs = (TabLayout) findViewById(R.id.tabs);
         mTabs.setupWithViewPager(mViewPager);
-
-        // set up the tab icons
-        for (int i = 0, count = mPagerAdapter.getCount(); i < count; ++i)
-        {
-            mTabs.getTabAt(i).setIcon(mPagerAdapter.getTabIcon(i));
-        }
+        setupTabIcons();
 
         mViewPager.addOnPageChangeListener(new OnPageChangeListener()
         {
@@ -309,6 +304,10 @@ else if (mCurrentPageId == R.id.task_group_search)
             @Override
             public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels)
             {
+                /* Icons need to be refreshed here because of an apparent bug in ViewPager-TabLayout
+                 See https://github.com/dmfs/opentasks/issues/643
+                 and https://stackoverflow.com/questions/42209046/tablayout-icons-disappear-after-viewpager-refresh */
+                mTabs.post(() -> setupTabIcons());
             }
 
 
@@ -347,6 +346,15 @@ public void onClick(View v)
     }
 
 
+    private void setupTabIcons()
+    {
+        for (int i = 0, count = mPagerAdapter.getCount(); i < count; ++i)
+        {
+            mTabs.getTabAt(i).setIcon(mPagerAdapter.getTabIcon(i));
+        }
+    }
+
+
     @Override
     protected void onResume()
     {
@@ -726,7 +734,7 @@ public void updateColor(Color color)
         {
             int colorInt = color.argb();
             getSupportActionBar().setBackgroundDrawable(new ColorDrawable(colorInt));
-            mTabs.setBackgroundColor(colorInt);
+//            mTabs.setBackgroundColor(colorInt);
 
             if (mAppBarLayout != null)
             {