Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(39): incorrect parsing and panic involving consecutive @if expressions and interpolation blocks #40

Closed

Conversation

ninoDeme
Copy link
Contributor

@ninoDeme ninoDeme commented Aug 8, 2024

fixes #39
Dirty fix to resolve the problem.

The change in scanner.c should fix the crash when the syntax tree is invalid and i wasn't able to find a way to fix the precedence rules of the @if statement without breaking the @else and @else if statements, so i just made the @else if and @else statements separate from the @if statement

@Ryntak94
Copy link

Out of curiosity, do you think this fix will address my issue? :)
#41

@dlvandenberg
Copy link
Owner

@ninoDeme Thanks for this. I was working on this before my holidays. I did miss the bug in the scanner. I've created a new PR #43

@dlvandenberg
Copy link
Owner

@Ryntak94 No that's a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants