rest_api: add troubleshooting section #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudolfix
requested changes
May 16, 2024
There was a problem hiding this comment.
What I'm lacking here: you do not tell the user when do certain action. I left some comments. Also I think we should mention how to troubleshot autodetections
- tell the user that is paginator is not specified we try to autodetect one. if autodetection fails or we are not sure, s/he will get a warning in the log. we recommend to put explicit paginator for production code
- same thing for data_selector. we'll try to detect a valid one but if you are getting weird data in the database you should provide a right one (we log what we guess at the INFO level)
rudolfix
requested changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.