optimized

loppeonline/apps/users/views.py

@@ -267,9 +267,9 @@ def dispatch(self, *args, **kwargs):
         return super(PasswordResetConfirmView, self).dispatch(*args, **kwargs)
 
     def post(self, request, *args, **kwargs):
-        res, reason = check_recaptcha(request)
+        result, reason = check_recaptcha(request)
 
-        if not res:
+        if not result:
             return Response(
                 {'error': _('Recaptcha error: {}'.format(reason))},
                 status=HTTP_403_FORBIDDEN,
@@ -571,7 +571,7 @@ def post(self, request, *args, **kwargs):
 
         required_params = ['username', 'password']
 
-        if not all([r_param in data for r_param in required_params]):
+        if not all(r_param in data for r_param in required_params):
             return JsonResponse(
                 {'error': _('Please provide both username and password')},
                 status=HTTP_400_BAD_REQUEST,
@@ -620,9 +620,9 @@ def post(self, request, *args, **kwargs):
 
         # Check recaptcha only for admins
         if user.is_admin:
-            res, reason = check_recaptcha(data)
+            result, reason = check_recaptcha(data)
 
-            if not res:
+            if not result:
                 return JsonResponse(
                     {'error': _('Recaptcha error: {}'.format(reason))},
                     status=HTTP_403_FORBIDDEN,
@@ -684,7 +684,7 @@ def post(self, request, *args, **kwargs):
             return super().post(request, *args, **kwargs)
         data = json.loads(body_unicode)
 
-        if not ('refresh_token' in data):
+        if 'refresh_token' not in data:
             return Response(
                 {'error': _('Please provide refresh_token')},
                 status=HTTP_400_BAD_REQUEST,