Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addes assert messages to bitmanip #7105

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Addes assert messages to bitmanip #7105

merged 1 commit into from
Jul 25, 2019

Conversation

burner
Copy link
Member

@burner burner commented Jul 10, 2019

No description provided.

@burner burner requested a review from andralex as a code owner July 10, 2019 10:23
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @burner!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7105"

@burner burner force-pushed the bitmanip_assert_messages branch from d754fe5 to 9e2fe61 Compare July 10, 2019 10:27
atilaneves
atilaneves reviewed Jul 10, 2019
View reviewed changes
std/bitmanip.d Outdated Show resolved Hide resolved
std/bitmanip.d Outdated
assert(numbits <= v.length * 8,
"numbits must be less than or equal to v.length * 8");
assert(v.length % size_t.sizeof == 0,
"v.length must be a multiple of the size of size_t");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

std/bitmanip.d Show resolved Hide resolved
@burner burner force-pushed the bitmanip_assert_messages branch from 9e2fe61 to 8c43f3d Compare July 11, 2019 07:32
@dlang-bot dlang-bot merged commit 5f399cf into dlang:master Jul 25, 2019
@burner
Copy link
Member Author

burner commented Jul 25, 2019

@n8sh thanks

@belka-ew belka-ew mentioned this pull request Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atilaneves atilaneves atilaneves approved these changes

@andralex andralex Awaiting requested review from andralex

Assignees
No one assigned
Labels
Merge:auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@burner @dlang-bot @atilaneves @n8sh