Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dt_t.nbytes accept a slice instead of size+pointer #20650

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 7, 2025

No description provided.

@dkorpel dkorpel added Severity:Refactoring No semantic changes to code Compiler:Backend glue code, optimizer, code generation labels Jan 7, 2025
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20650"

@dkorpel dkorpel force-pushed the dt-slice branch 2 times, most recently from 8cb42d8 to 44e9445 Compare January 7, 2025 19:18
@dkorpel dkorpel marked this pull request as ready for review January 7, 2025 19:23
@thewilsonator
Copy link
Contributor

Looks good but merge conflict

@dkorpel dkorpel merged commit 73c4b28 into dlang:master Jan 8, 2025
40 of 41 checks passed
@dkorpel dkorpel deleted the dt-slice branch January 8, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler:Backend glue code, optimizer, code generation Merge:auto-merge Severity:Refactoring No semantic changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants