Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subtracting pointers of different types an error #20577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thewilsonator
Copy link
Contributor

No description provided.

@thewilsonator thewilsonator added Review:WIP Work In Progress - not ready for review or pulling Severity:Deprecation -> Error labels Dec 18, 2024
@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 18, 2024

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20577"

@thewilsonator thewilsonator force-pushed the pointer-subtract branch 2 times, most recently from 6e4c18a to d70abe5 Compare December 18, 2024 22:20
@thewilsonator thewilsonator added Review:Needs Changelog A changelog entry needs to be added to /changelog and removed Review:WIP Work In Progress - not ready for review or pulling labels Dec 18, 2024
@thewilsonator thewilsonator force-pushed the pointer-subtract branch 2 times, most recently from df97364 to fc2dde1 Compare January 8, 2025 05:58
@thewilsonator thewilsonator added Review:Ready To Merge Let's get this merged and removed Review:Needs Changelog A changelog entry needs to be added to /changelog labels Jan 8, 2025
@thewilsonator thewilsonator force-pushed the pointer-subtract branch 2 times, most recently from a63d5d3 to f53856d Compare January 8, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants