Add Kernighan & Ritchie style brace formatting #534
Conversation
The original K&R style behaves like BraceStyle.otbs, except for function definitions that use Allman style.
|
Should be noted that I've taken the "otbs" tests and adjusted them by hand to fit the "knr" style. |
|
Any chance of someone having a look at this? Would be nice to be able to use dfmt as a tool for contributions to vibe.d related projects. Note that the actual change is pretty small, it's just a lot of test cases added. |
src/dfmt/ast_info.d
Outdated
| { | ||
| if (auto bd = functionBody.specifiedFunctionBody) | ||
| { | ||
| astInformation.funBodyLocations ~= bd.blockStatement.startLocation; |
There was a problem hiding this comment.
there could be a null dereference here if bd.blockStatement is null.
However with the current grammar this case is impossible, it could only be introduced in the future. I don't think it's very likely that this will happen to blockStatement (as shortened statement got a separate AST name), so I am fine with merging without checking for null here
|
I think in general it would be better if all of these states were tweakable separately, but would merge this one for now anyway. Would like to know what @Hackerpilot thinks before merging too though. |
|
Agreed that separate switches would be preferable (IMO), but I gathered that the project vision was to be more opinionated rather than supporting customization. @Hackerpilot doesn't seem to be engaged much with open-source projects lately, though, so the question is how/if we can continue with this. |
|
would merge today unless he appears then |
|
Still under the radar... |
|
thanks for reminder |
The original K&R style behaves like BraceStyle.otbs, except for function definitions that use Allman style.
See https://en.wikipedia.org/wiki/Indentation_style#K&R_style