fix dub dependency build (fix #413) #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2018
LaurentTreguier
approved these changes
Dec 9, 2018
|
did you test on windows? I'm not 100% sure if the forward slash will also work on windows, but I am guessing it should work. If it does work I think this is mergable |
|
Didn't think of that, but forward slashes have always worked on Windows for me... I'll still check just in case though |
|
Doesn't seem to pose any problem. Forward slashes should be avoided for basic windows commands, for example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run rdmd with
$PACKAGE_DIRdub variable for an absolute path. The dubhash.d already uses the environment variable set by dub which tells it where the package is