Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and correct error message on duplicated keys #306

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Aug 23, 2022

The previous error message was using the wrong startMark,
and didn't give the key information.

The previous error message was using the wrong startMark,
and didn't give the key information.
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #306 (9c24e98) into master (0eb040e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   95.17%   95.20%   +0.02%     
==========================================
  Files          29       29              
  Lines        4559     4564       +5     
==========================================
+ Hits         4339     4345       +6     
+ Misses        220      219       -1     
Impacted Files Coverage Δ
source/dyaml/composer.d 96.69% <100.00%> (+0.14%) ⬆️
source/dyaml/node.d 91.85% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb040e...9c24e98. Read the comment docs.

@Geod24 Geod24 requested a review from Herringway August 24, 2022 03:53
@Geod24 Geod24 merged commit 0fce9c0 into dlang-community:master Aug 24, 2022
@Geod24 Geod24 deleted the improve-error-message branch August 24, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants