[BUG] [Formatter] long textarea in twig - line wrapping does not work

[palansher]

Issue

Your Djlint becomes better and better. Thank you!

How To Reproduce

I cannot reformat such long lines

<textarea type="textarea" id="messageContent" name="adContent" maxlength="300" class="form-control" rows="10">{{ adContent|default }}</textarea>

for like this:

<textarea 
               type="textarea" 
               id="messageContent" 
               name="adContent" 
               maxlength="300"  
               class="form-control" 
               rows="10">
               {{ adContent|default }}
</textarea>

It still one long line.
Same time, the long 'inputs' and 'divs' are wrapped well.

Please give your helping hand!

---

BTW,

By, according to my observations, for textareas

this style

<textarea 
               content</textarea>

is more prefferable then this

<textarea 
               content
</textarea>

Because in the second variant the browser adds extra ugly <CR/LF> trash to the end of content of textarea field.
It happens when we have the combination of next three consistently: "content text" + line feed + "</textarea>".
So, the middle line feed makes the problem.

---

my conf:

.djlintrc

{
    "ignore": "H021,H030,H031,H017,H023,H014,H006",
    "extension": "twig",
    "indent": "4",
    "profile": "nunjucks",
    "format_attribute_template_tags": false,
    "max_line_length": "110",
    "max_attribute_length": "100",
    "preserve_blank_lines": "true"
}

• I'm on the latest version of djLint
• I've searched the issues
• I've read the docs

System Info

• OS: e.g. ubuntu 20.04
• Python Version 3.8.10
• djLint Version 1.19.7
• template language: twig

[christopherpickering]

🎉 This issue has been resolved in version 1.19.8 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[palansher]

🎉 This issue has been resolved in version 1.19.8 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

Hello Chris!

Unfortunately, no change for textarea.

vladp@dev:~$ djlint --version
djlint, version 1.19.8

This code

<textarea type="textarea" id="messageContent" name="adContent" maxlength="300" class="form-control" rows="10">{{ adContent|default }}</textarea>

is reformatting to one line back even if I format it manually and the settings are:

"max_line_length": "110",
"max_attribute_length": "100",

I extracted this textarea attribute alone to separate file. No Changes.

[palansher]

Even out of VS code extension:

djlint --reformat test.html.twig 

Reformatting 1/1 files ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 00:00    


0 files were updated.

✔ ~/dev/gtdev-advert/templates/admin/app [advert|✚ 7…3] 
15:34 $ cat test.html.twig 
<textarea type="textarea" id="messageContent" name="adContent" maxlength="300" class="form-control" rows="10">{{ adContent|default }}</textarea>

[christopherpickering]

hmm, its odd, I will check it out. The new test is passing nicely. https://github.com/Riverside-Healthcare/djLint/blob/68c155a7cf74e4e5e7db6911ab4c5dd8551137ca/tests/test_html/test_tag_textarea.py#L81

[palansher]

BTW:
I just noticed that my 'type="textarea"' inside <textarea> tag is non-standard, according https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea.

I removed it and .. no changes.

[christopherpickering]

no problem, we don't check for anything being standard except for changing case ;)

[christopherpickering]

I tried it out in the online demo and it is working:

can you send more surrounding html or a full file?

[palansher]

Holy cow ! You have demo page!!

hope, files can help:
files.zip

[palansher]

hmm, I have cleaned up (just left {} ) config file and vua-la, it formats well!!!

But I see nothing illegal inside it (included in zip above).

[christopherpickering]

thanks! I'll check it out!

[christopherpickering]

I think I found the bug.. I'll see about getting a change out soon.

the --check flag + stdin was not writing the formatted code back and just retuning the original.

[christopherpickering]

🎉 This issue has been resolved in version 1.19.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[palansher]

Alas! the same:

21:08 $ djlint --reformat test.html.twig 

Reformatting 1/1 files ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 00:00    


0 files were updated.

✔ ~/dev/gtdev-advert/templates/admin/app [advert|✚ 12…5] 
21:08 $ djlint --version
djlint, version 1.19.9
✔ ~/dev/gtdev-advert/templates/admin/app [advert|✚ 12…5] 
21:08 $ cat test.html.twig 
<textarea type="textarea" id="messageContent" name="adContent" maxlength="300" class="form-control" rows="10">{{ adContent|default }}</textarea>
✔ ~/dev/gtdev-advert/templates/admin/app [advert|✚ 12…5] 

config is the same:

✔ ~/dev/gtdev-advert [advert|✚ 12…5] 
21:11 $ cat .djlintrc 
{
    "ignore": "H021,H030,H031,H017,H023,H014,H006",
    "extension": "twig",
    "indent": "4",
    "profile": "nunjucks",
    "format_attribute_template_tags": false,
    "max_line_length": "110",
    "max_attribute_length": "100",
    "preserve_blank_lines": "true"

}

[christopherpickering]

ty, will keep looking :) Your bugs always escape..

[christopherpickering]

@palansher try reducing the max_attribute_length to something smaller, or even 0 if you want attributes to always be formatted.

{
    "ignore": "H021,H030,H031,H017,H023,H014,H006",
    "extension": "twig",
    "indent": "4",
    "profile": "nunjucks",
    "format_attribute_template_tags": false,
    "max_line_length": "110",
    "max_attribute_length": "50",
    "preserve_blank_lines": "true"

}

will make it format.

[christopherpickering]

@palansher hope things are well, haven't heard from you here in a while 😅 no bugs I guess 😁

[Joyfred]

@christopherpickering max_line_length is not honoured for .jinja extensions