Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.8.4 version #208

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Bump to 0.8.4 version #208

merged 1 commit into from
Jun 14, 2024

Conversation

pfreixes
Copy link
Contributor

We need to have this merged first

bb8/Cargo.toml Outdated
@@ -1,6 +1,6 @@
[package]
name = "bb8"
version = "0.8.3"
version = "0.9.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 0.8.4? I think all of your changes have been semver-compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since its adding a new feature and not patching anything got the feeling that minor bump would be the most suitable one to bump.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we keep compatibility

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not how semver works in Cargo: 0.x to 0.y is a semver-incompatible bump, there is no distinction between feature and fix versions in 0.x versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware about this change from Cargo compared to what we have historically used major, minor and patched versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill put the 0.8.4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and thanks for the insights here about how Cargo works with versions

@pfreixes pfreixes changed the title Bump to 0.9.0 version Bump to 0.8.4 version Jun 14, 2024
@djc djc merged commit 5275f1a into djc:main Jun 14, 2024
7 of 8 checks passed
@djc
Copy link
Owner

djc commented Jun 14, 2024

  • Published bb8 v0.8.4 at registry crates-io
  • [new tag] v0.8.4 -> v0.8.4

Thanks!

@pfreixes
Copy link
Contributor Author

Seems that the documentation is not providing all the details https://docs.rs/bb8/0.8.4/bb8/struct.State.html did we miss something for having the new Statistic struct being added in the documentation?

@djc
Copy link
Owner

djc commented Jun 14, 2024

Ahh, we probably need to re-export Statistics in lib.rs. Do you want to send a PR to do that, including another commit to bump the version to 0.8.5? (You can run cargo doc --open --no-deps to check the generated docs before submitting the PR.)

@pfreixes
Copy link
Contributor Author

Yeps, give me some seconds

@pfreixes
Copy link
Contributor Author

Here we go #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants