-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 0.8.4 version #208
Conversation
bb8/Cargo.toml
Outdated
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "bb8" | |||
version = "0.8.3" | |||
version = "0.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 0.8.4? I think all of your changes have been semver-compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since its adding a new feature and not patching anything got the feeling that minor bump would be the most suitable one to bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we keep compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not how semver works in Cargo: 0.x to 0.y is a semver-incompatible bump, there is no distinction between feature and fix versions in 0.x versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not aware about this change from Cargo compared to what we have historically used major, minor and patched versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill put the 0.8.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, and thanks for the insights here about how Cargo works with versions
Thanks! |
Seems that the documentation is not providing all the details https://docs.rs/bb8/0.8.4/bb8/struct.State.html did we miss something for having the new |
Ahh, we probably need to re-export |
Yeps, give me some seconds |
Here we go #209 |
We need to have this merged first