Does the transaction have some problem? (GnuCash-Pocket#97)

djbrown · Jun 2, 2024 · d3af73d · d3af73d
1 parent b1eb324
commit d3af73d
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 12 deletions.
diff --git a/app/src/main/java/org/gnucash/android/ui/transaction/ScheduledActionsListFragment.java b/app/src/main/java/org/gnucash/android/ui/transaction/ScheduledActionsListFragment.java
@@ -58,6 +58,7 @@
 import org.gnucash.android.db.adapter.TransactionsDbAdapter;
 import org.gnucash.android.export.ExportParams;
 import org.gnucash.android.model.ScheduledAction;
+import org.gnucash.android.model.Split;
 import org.gnucash.android.model.Transaction;
 import org.gnucash.android.ui.common.FormActivity;
 import org.gnucash.android.ui.common.UxArgument;
@@ -474,13 +475,20 @@ public void bindView(View view, Context context, Cursor cursor) {
             Transaction transaction = mTransactionsDbAdapter.buildModelInstance(cursor);
 
             TextView amountTextView = (TextView) view.findViewById(R.id.right_text);
-            if (transaction.getSplits().size() == 2) {
-                if (transaction.getSplits().get(0).isPairOf(transaction.getSplits().get(1))) {
-                    amountTextView.setText(transaction.getSplits().get(0).getValue().formattedString());
+            String text = "";
+            List<Split> splits = transaction.getSplits();
+            if (splits.size() == 2) {
+                Split first = splits.get(0);
+                for (Split split : splits) {
+                    if ((first != split) && first.isPairOf(split)) {
+                        text = first.getValue().formattedString();
+                        break;
+                    }
                 }
             } else {
-                amountTextView.setText(getString(R.string.label_split_count, transaction.getSplits().size()));
+                text = getString(R.string.label_split_count, splits.size());
             }
+            amountTextView.setText(text);
             TextView descriptionTextView = (TextView) view.findViewById(R.id.secondary_text);
 
             ScheduledActionDbAdapter scheduledActionDbAdapter = ScheduledActionDbAdapter.getInstance();

diff --git a/app/src/main/java/org/gnucash/android/ui/transaction/TransactionsListFragment.java b/app/src/main/java/org/gnucash/android/ui/transaction/TransactionsListFragment.java
@@ -22,6 +22,7 @@
 import android.content.res.Configuration;
 import android.database.Cursor;
 import android.os.Bundle;
+import android.text.TextUtils;
 import android.view.LayoutInflater;
 import android.view.Menu;
 import android.view.MenuInflater;
@@ -306,20 +307,27 @@ public void onClick(View v) {
 
                 List<Split> splits = SplitsDbAdapter.getInstance().getSplitsForTransaction(transactionUID);
                 String text = "";
-
-                if (splits.size() == 2 && splits.get(0).isPairOf(splits.get(1))) {
-                    for (Split split : splits) {
-                        if (!split.getAccountUID().equals(mAccountUID)) {
-                            text = AccountsDbAdapter.getInstance().getFullyQualifiedAccountName(split.getAccountUID());
-                            break;
+                String error = null;
+
+                if (splits.size() == 2) {
+                    if (splits.get(0).isPairOf(splits.get(1))) {
+                        for (Split split : splits) {
+                            if (!split.getAccountUID().equals(mAccountUID)) {
+                                text = AccountsDbAdapter.getInstance().getFullyQualifiedAccountName(split.getAccountUID());
+                                break;
+                            }
                         }
                     }
+                    if (TextUtils.isEmpty(text)) {
+                        text = getString(R.string.label_split_count, splits.size());
+                        error = getString(R.string.imbalance_account_name);
+                    }
                 }
-
                 if (splits.size() > 2) {
-                    text = splits.size() + " splits";
+                    text = getString(R.string.label_split_count, splits.size());
                 }
                 holder.secondaryText.setText(text);
+                holder.secondaryText.setError(error);
                 holder.transactionDate.setText(dateText);
 
                 holder.editTransaction.setOnClickListener(new View.OnClickListener() {