-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganized locale directories and added Transifex for managing the translation process #866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to what I've written in email, it occures that I didn't published my review (can't do it in mobile view, had to switch to desktop). Sorry for confusion.
Publishing now :)
And your translation at work: https://www.dropbox.com/s/6vjkpxhmbde61dk/Screenshot%202019-02-18%2021.57.32.png?dl=0 😄 |
@m-aciek Would you like to give this another review? And/or @timgraham would you like to review before merging? Thanks! |
@@ -0,0 +1,26 @@ | |||
# SOME DESCRIPTIVE TITLE. | |||
# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER | |||
# This file is distributed under the same license as the PACKAGE package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs' PO files have sth more similar to:
# This file is distributed under the same license as the PACKAGE package. | |
# Copyright (C) Django Software Foundation and contributors | |
# This file is distributed under the same license as the djangoproject.com source files. |
here.
Should it be set in Transifex to work automatically?
If it is configurable, I'd also suggest to drop the lines SOME DESCRIPTIVE TITLE.
and FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is mostly controlled by Transifex, I don't know yet if that can be customized or not. We could also remove French files from this commit, and add them with other languages in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it can be changed in Transifex that would be great. Do you know if that's possible and where to do it if so? I'm not finding anything in the UI or their documentation...
Or for the Django docs is it handled through post-processing (like removal of the file locations)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly me. I just needed to change this in the source file, and then push/pull to update in the translations.
…f dashboard/docs strings from top-level PO file
…lations for the docs themselves
This should be ready for another review. |
We had some old PO files for English and French in the repo, but they were sorely out of date and it's high time we switched to something more modern for managing the translation process. I also discovered recently that we were not running
compilemessages
during deploy, so the few translations we did have weren't even showing up. That has now been fixed, so let's add and update translations! 😄This PR:
locale
directories in thedashboard
app and at the project level (in addition todocs/locale/
that we already had). This gives us onelocale/
directory for each website domain and allows us to map the corresponding PO files to different places in Transifex.transifex-client
to the dev requirements, a new.tx/config
to do the locale -> resource mapping, and some process docs for managing translations.Much credit due to @m-aciek and @claudep for helping to brainstorm and arrive at this solution!
One question: I copied the list of supported languages from the script in django-docs-translations, but I'm not sure if we need to keep those in sync or not. I guess we should at least aim to support at least those languages but potentially more, for djangoproject.com...(?)
Finally, a few things that can or will happen separately from this PR: