Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Distrito Federal" has legally changed name. #400

Closed
wants to merge 1 commit into from

Conversation

bravohome
Copy link

@bravohome bravohome commented Feb 12, 2020

"Distrito Federal" is no longer the name of the state as it has changed to "Ciudad de México".
Do not change key 'DIF' if you already have your database populated.

A checklist is included below which helps us keep the code contributions
consistent and helps speed up the review process. You can add additional
commits to your pull request if you haven't met all of these points on your
first version.

All Changes

  • Add an entry to the docs/changelog.rst describing the change.

  • Add an entry for your name in the docs/authors.rst file if it's not
    already there.

New Fields Only

  • Prefix the country code to all fields.

  • Field names should be easily understood by developers from the target
    localflavor country. This means that English translations are usually
    not the best name unless it's for something standard like postal code,
    tax / VAT ID etc.

  • Prefer 'PostalCodeField' for postal codes as it's
    international English; ZipCode is a term specific to the United
    States postal system.

  • Add meaningful tests. 100% test coverage is not required but all
    validation edge cases should be covered.

  • Add .. versionadded:: <next-version> comment markers to new
    localflavors.

  • Add documentation for all fields.

"Distrito Federal" is no longer the name of the state as it has changed to "Ciudad de México".
Do not change key 'DIF' if you already have your database populated.
@benkonrath benkonrath added this to the 3.0 milestone Feb 14, 2020
@benkonrath
Copy link
Member

Let's take care of this one in the next release (3.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants