Add Kalimantan Utara in list of provinces of Indonesia #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2019 09:26
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 161 161
Lines 3978 3978
Branches 530 530
=======================================
Hits 3813 3813
Misses 99 99
Partials 66 66
Continue to review full report at Codecov.
|
Change test to use translated messages
|
Thanks for the PR! It would be better if you split this change into 2 separate pull requests. The easiest thing to do is remove the changes to the national identity number and make a new PR. Thanks. |
added 2 commits
July 29, 2019 14:01
…est to use translated messages" This reverts commit 8452374
|
reverted the change and moved to different PR |
|
Sorry for the delay on this. Thanks again for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Kalimantan Utara province for Indonesia's List of provinces
Thanks for your contribution!
A checklist is included below which helps us keep the code contributions
consistent and helps speed up the review process. You can add additional
commits to your pull request if you haven't met all of these points on your
first version.
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.