Gil obradors created es models - rebase #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added models for ES-ID document and ES-PostalCodes
Models for National-ID and PostalCodes
Add DNI and Postalcode model Isorted
orthographic error
The official name is Araba/Álava: https://en.wikipedia.org/wiki/%C3%81lava This change should be made in separate PR.
* Remove spaces and dashes before saving to database * Change identity card field length to 9 * Add tests
|
@gil-obradors I've made a few changes your PR so that it can be included in the 2.2 release. Here's an overview:
It would be great if you can look over the changes if you have time. I'm planning to merge this into master tomorrow. Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 95.96% 95.94% -0.03%
==========================================
Files 160 161 +1
Lines 4068 4095 +27
Branches 527 528 +1
==========================================
+ Hits 3904 3929 +25
- Misses 99 100 +1
- Partials 65 66 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gil-obradors This is a rebase of your PR (#357). The merges were too confusing to read and I want to cleanup and merge this PR in time for the 2.2 release.
Closes #357