Add 34 prefix value (ar localflavor ARCUITField). #342
Conversation
localflavor/ar/forms.py
Outdated
| @@ -11,7 +11,8 @@ | |||
|
|
|||
|
|
|||
| class ARProvinceSelect(Select): | |||
| """A Select widget that uses a list of Argentinean provinces/autonomous cities as its choices.""" | |||
| """A Select widget that uses a list of Argentinean provinces/autonomous | |||
| cities as its choices.""" | |||
There was a problem hiding this comment.
I think that we generally go to next line after """ when it takes more than one line, but that's nit-picking...
There was a problem hiding this comment.
I agree. We're using 120 character lines so you can also just not include this change. Either way is fine.
There was a problem hiding this comment.
Thanks for your contribution! Nice to see that you added a test for this change. And thanks for correcting the small typos you found.
If you could make the 2 small updates, I will merge this. It would be nice to get this into the 2.1 release that I'm planning to do in a couple of weeks.
I can also make the changes if that's easier. Just let me know.
localflavor/ar/forms.py
Outdated
| @@ -11,7 +11,8 @@ | |||
|
|
|||
|
|
|||
| class ARProvinceSelect(Select): | |||
| """A Select widget that uses a list of Argentinean provinces/autonomous cities as its choices.""" | |||
| """A Select widget that uses a list of Argentinean provinces/autonomous | |||
| cities as its choices.""" | |||
There was a problem hiding this comment.
I agree. We're using 120 character lines so you can also just not include this change. Either way is fine.
localflavor/ar/forms.py
Outdated
|
|
||
| More info: | ||
| http://es.wikipedia.org/wiki/Clave_%C3%9Anica_de_Identificaci%C3%B3n_Tributaria | ||
|
|
||
| English info: | ||
| Info in English: | ||
| http://www.justlanded.com/english/Argentina/Argentina-Guide/Visas-Permits/Other-Legal-Documents | ||
| """ |
There was a problem hiding this comment.
It would be great if you could add .. versionchanged:: 2.1 here.
|
Thank you for your reviews! I think I've taken care of them. |
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 153 153
Lines 3878 3878
Branches 517 517
=======================================
Hits 3716 3716
Misses 98 98
Partials 64 64
Continue to review full report at Codecov.
|
There are now CUIT assigned that use a 34 prefix. This PR adds support for it.
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command: