Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate NL SoFiNumber fields and add BSN fields. #314

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

benkonrath
Copy link
Member

Ref #150

@codecov-io
Copy link

codecov-io commented Nov 22, 2017

Codecov Report

Merging #314 into master will decrease coverage by <.01%.
The diff coverage is 97.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   96.28%   96.28%   -0.01%     
==========================================
  Files         156      156              
  Lines        4389     4415      +26     
  Branches      592      592              
==========================================
+ Hits         4226     4251      +25     
- Misses        102      103       +1     
  Partials       61       61
Impacted Files Coverage Δ
localflavor/nl/forms.py 100% <100%> (ø) ⬆️
localflavor/nl/models.py 100% <100%> (ø) ⬆️
localflavor/nl/validators.py 98.63% <93.33%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6fcf8...58b7d0d. Read the comment docs.

@benkonrath benkonrath merged commit 35fbafd into django:master Nov 22, 2017
@benkonrath benkonrath deleted the deprecate-nl-sofi-number branch December 5, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants