Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations and cleanups #305

Merged
merged 3 commits into from
Jul 21, 2017

Conversation

benkonrath
Copy link
Member

@codecov-io
Copy link

codecov-io commented Jul 20, 2017

Codecov Report

Merging #305 into master will decrease coverage by 0.01%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage    96.3%   96.28%   -0.02%     
==========================================
  Files         152      152              
  Lines        4221     4230       +9     
  Branches      579      579              
==========================================
+ Hits         4065     4073       +8     
- Misses         97       98       +1     
  Partials       59       59
Impacted Files Coverage Δ
localflavor/generic/forms.py 100% <ø> (ø) ⬆️
localflavor/generic/models.py 100% <ø> (+2.27%) ⬆️
localflavor/tr/forms.py 87.27% <100%> (ø) ⬆️
localflavor/nl/models.py 100% <100%> (ø) ⬆️
localflavor/pk/forms.py 100% <100%> (ø) ⬆️
localflavor/be/forms.py 100% <100%> (ø) ⬆️
localflavor/no/forms.py 88.04% <100%> (ø) ⬆️
localflavor/in_/forms.py 96.87% <100%> (ø) ⬆️
localflavor/pt/forms.py 100% <100%> (ø) ⬆️
localflavor/ch/forms.py 88.88% <100%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a984b6a...da7d4e7. Read the comment docs.

@claudep
Copy link
Member

claudep commented Jul 21, 2017

Fine, but do we gain anything by removing 1.9 support? If not, I wonder if it's worth it.

@benkonrath benkonrath force-pushed the deprecations-and-cleanups branch from bdadced to 7e480bb Compare July 21, 2017 08:46
@benkonrath benkonrath force-pushed the deprecations-and-cleanups branch from 7e480bb to 20acf7d Compare July 21, 2017 09:02
@benkonrath
Copy link
Member Author

There's no specific gain for dropping support for 1.9 except being explicit about not supporting version of Django that are no longer supported. I'll remove this change for now.

@benkonrath benkonrath force-pushed the deprecations-and-cleanups branch from 20acf7d to da7d4e7 Compare July 21, 2017 09:12
@claudep
Copy link
Member

claudep commented Jul 21, 2017

I see your point. But as we generally gain nothing technically when dropping "intermediate" unsupported releases, my opinion is that we should keep that support. But this is in no way a final decision and this might be the subject of further discussions (e.g. on django-developers).

@benkonrath
Copy link
Member Author

benkonrath commented Jul 21, 2017

Yeah, I understand it's just your opinion and I also see your point. For me it's not really a big deal either way - I dropped 1.9 support to save me a bit of time waiting for CI test and because I don't want to fix any bugs in old versions of Django. But we can just decide to drop support if or when 1.9 (or any other unsupported version) is holding us back like we have in the past.

@benkonrath benkonrath merged commit b0fe8da into django:master Jul 21, 2017
@benkonrath benkonrath deleted the deprecations-and-cleanups branch July 21, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants