-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecations and cleanups #305
Deprecations and cleanups #305
Conversation
benkonrath
commented
Jul 20, 2017
- More work on depreciations (see Depricate non pep8 compliant class and method names #258).
- Drop support for Django 1.9
- Small cleanup for IBAN tests.
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
- Coverage 96.3% 96.28% -0.02%
==========================================
Files 152 152
Lines 4221 4230 +9
Branches 579 579
==========================================
+ Hits 4065 4073 +8
- Misses 97 98 +1
Partials 59 59
Continue to review full report at Codecov.
|
Fine, but do we gain anything by removing 1.9 support? If not, I wonder if it's worth it. |
bdadced
to
7e480bb
Compare
7e480bb
to
20acf7d
Compare
There's no specific gain for dropping support for 1.9 except being explicit about not supporting version of Django that are no longer supported. I'll remove this change for now. |
20acf7d
to
da7d4e7
Compare
I see your point. But as we generally gain nothing technically when dropping "intermediate" unsupported releases, my opinion is that we should keep that support. But this is in no way a final decision and this might be the subject of further discussions (e.g. on django-developers). |
Yeah, I understand it's just your opinion and I also see your point. For me it's not really a big deal either way - I dropped 1.9 support to save me a bit of time waiting for CI test and because I don't want to fix any bugs in old versions of Django. But we can just decide to drop support if or when 1.9 (or any other unsupported version) is holding us back like we have in the past. |