issue #214 fixed pep8, pep257 and other styling errors to pass the pr… #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
511d883 to
140f73a
Compare
benkonrath
requested changes
Nov 6, 2016
| A model field that is represented with | ||
| :data:`~localflavor.au.au_states.STATE_CHOICES`` choices and | ||
| stores the three-letter Australian state abbreviation in the database. | ||
| A model field stores the three-letter Australian state abbreviation in the database. |
There was a problem hiding this comment.
This should be: "A model field that stores ..."
| if value not in valid_values: | ||
| raise ValidationError(self.error_messages['invalid']) | ||
| return value | ||
|
|
||
|
|
||
| def DV_maker(v): | ||
| def dv_maker(v): |
There was a problem hiding this comment.
This public method needs to be deprecated before it's changed. Can you add a note about this to #258?
There was a problem hiding this comment.
I have added a DV_maker method that uses dv_maker for backwards compatibility
| raise ValidationError(self.error_messages['invalid']) | ||
|
|
||
| if value[:6] == '000000' or value[12:] == '0000': | ||
| raise ValidationError(self.error_messages['invalid']) | ||
|
|
||
| return '%s.%s.%s.%s' % (value[:2], value[2:6], value[6:12], value[12:]) | ||
|
|
||
| @staticmethod | ||
| def _valid_nik_date(year, month, day): |
There was a problem hiding this comment.
Again this is a public method that's being changed.
There was a problem hiding this comment.
def valid_nik_date(year, month, day): is not a public method, it is a local function inside the clean method so it is not exposed publicly
| stores the five-letter Pakistani state abbreviation in the database. | ||
| A model field that stores the five-letter Pakistani state abbreviation in the database. | ||
|
|
||
| It is represented with :data:`~localflavor.pk.pk_states.STATE_CHOICES`` choices and. |
There was a problem hiding this comment.
The extra 'and' at the end should be removed.
* Fixed pep8, pep257 and other styling errors to pass the prospector validation. * Added custom prospector config that skips pep8 n802 checks (because the naming in tests is not compliant, but is conventional). * Some of the errors have been hidden by # noqa comments and added as a separate issue django#258. * Turned on prospector in tox.ini. fixes django#214
140f73a to
9fd659c
Compare
|
Looks good. Thanks! |
benkonrath
approved these changes
Nov 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed most pep8, pep257 and other styling errors that didn't let prospector validate
Added a custom config for prospector, that inherits hygh_strictness, but has a line length setting changed to 120, and has pep8 N802 disabled because it is conflicting with test naming.
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command: