Adding local flavor for Venezuela #245
Conversation
There was a problem hiding this comment.
Thanks for the contribution. There are a couple of mistakes in the data. On the English wikipedia page you can order the table by subdivision name which is how I found the problems.
You'll also need to rebase with master. Thanks.
https://en.wikipedia.org/wiki/ISO_3166-2:VE
| #: A list of Venezuelan states for use as `choices` in a formfield. | ||
| #: Data based from ISO_3166-2:VE http://en.wikipedia.org/wiki/ISO_3166-2:VE | ||
| STATE_CHOICES = ( | ||
| ('VE-X', _('Amazonas')), |
| ('VE-G', _('Carabobo')), | ||
| ('VE-H', _('Cojedes')), | ||
| ('VE-Y', _('Delta Amacuro')), | ||
| ('VE-Z', _('Dependencias Federales')), |
| ('VE-R', _('Sucre')), | ||
| ('VE-S', _('Táchira')), | ||
| ('VE-T', _('Trujillo')), | ||
| ('VE-W', _('Vargas')), |
|
Hi, @benkonrath thanks for your comments. I already fixed the data errors on my local copy based on your feedback. What do you mean with:
. |
- Adds data and Select Widget for Venezuela regions - Adds data and widget to select venezuelan states - Adds changelog and author information to doc files - Adds tests
|
@jackboot7 Here's a guide that found that explains how to do a rebase: You'll have to resolve the conflict in the authors file. I can understand that it might a little overwhelming so I can resolve and merge this pull request if you prefer. Just let me know. |
|
@benkonrath Fixed the conflicts and rebased the code. Still not sure if I did the rebasing thing the right way... Anyway, if you have any comments they'll be appreciated. |
|
Looks good. Thanks for your contribution to django-localflavor! |
Changes
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command:
isort --recursive --line-width 120 localflavor testsNew Fields Only
localflavor country. This means that English translations are usually
not the best name unless it's for something standard like postal code,
tax / VAT ID etc.