Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ AUTaxFileNumberField #238

Closed
wants to merge 1 commit into from

Conversation

FrancoisConstant
Copy link
Contributor

@FrancoisConstant FrancoisConstant commented Jun 24, 2016

Hello,

I've added AUTaxFileNumberField (form and model) + AUTaxFileNumberFieldValidator.

It's based on the AUBusinessNumberField.

This is my first contribution and I hope it's all good.

All Changes

  • Add an entry to the docs/changelog.rst describing the change.

  • Add an entry for your name in the docs/authors.rst file if it's not
    already there.

  • Adjust your imports to a standard form by running this command:

    isort --recursive --line-width 120 localflavor tests

New Fields Only

  • Prefix the country code to all fields.
  • Field names should be easily understood by developers from the target
    localflavor country. This means that English translations are usually
    not the best name unless it's for something standard like postal code,
    tax / VAT ID etc.
  • Prefer 'PostalCodeField' for postal codes as it's
    international English; ZipCode is a term specific to the United
    States postal system.
  • Add meaningful tests. 100% test coverage is not required but all
    validation edge cases should be covered.
  • Add .. versionadded:: <next-version> comment markers to new
    localflavors.
  • Add documentation for all fields.

@benkonrath
Copy link
Member

Thanks for your contribution. I'll be able to review this over the weekend during the Dutch Django sprint.

@benkonrath benkonrath self-assigned this Jun 29, 2016
@@ -13,6 +13,8 @@ New fields for existing flavors:
- Added MXCLABEField model and form fields.
(`gh-227 <https://github.com/django/django-localflavor/pull/227>`_).

- Added AUTaxFileNumberField model and form fields.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the this github issue like the other changelog entries.

@benkonrath
Copy link
Member

Looks great! Thanks for your contribution. Please update the changelog as requested and rebase / squash all the commits into one commit. Once that this done I'll merge this PR. Thanks.

@FrancoisConstant
Copy link
Contributor Author

Thanks @benkonrath - the commits are squashed.

@benkonrath
Copy link
Member

Merged via fd9fcf1.

@benkonrath benkonrath closed this Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants