Adding support for Kuwait governorates #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce92668 to
c1831b2
Compare
| ('JA', _('Jahra')), | ||
| ('KU', _('Capital')), | ||
| ('HA', _('Hawalli')), | ||
| ('MU', _('Mubarak Al Kabir')), |
There was a problem hiding this comment.
I think it would be better to use the full ISO_3166-2:KW code for these (e.g.' KW-AH').
There was a problem hiding this comment.
I wouldn't mind that - except in Real Life - the KW- is not used, so doesn't make sense to keep it here.
c1831b2 to
2e80b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a select field that enumerates the 6 governorates of Kuwait; as per ISO 3166-2
Note that in the wikipedia entry they are listed as subdivision but they are actually governorates.