Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MXCLABEField for Mexico #227

Closed
wants to merge 1 commit into from
Closed

Conversation

scaramagus
Copy link
Contributor

This pull request adds a custom field for Clave Bancaria Estandarizada, used in all financial transactions in Mexico.

More info (in spanish):
https://es.wikipedia.org/wiki/CLABE

@scaramagus scaramagus force-pushed the master branch 7 times, most recently from 4ade079 to edc5323 Compare April 19, 2016 14:36
@benkonrath benkonrath self-assigned this Apr 25, 2016
@benkonrath benkonrath added this to the 1.3 milestone Apr 25, 2016
@scaramagus scaramagus force-pushed the master branch 4 times, most recently from b2bdd13 to 73b7969 Compare May 3, 2016 01:23
The remaining 12 digits denote an account number, plus a verifying digit.

More info:
https://es.wikipedia.org/wiki/CLABE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to the English version of this wikipedia page?

@benkonrath
Copy link
Member

Thanks for this contribution! Just those small points to fix up. I was hoping to get this into the 1.3 release which I want to release 6 or 7 May.

It probably makes sense to also get the Spanish translations included with the release of this feature which means you'd need to add the translations in Transifex after this is merged. If you don't have access to Transifex , the timing won't work for the 1.3 release.

@scaramagus
Copy link
Contributor Author

scaramagus commented May 5, 2016

@benkonrath Thanks for the feedback! I made the changes you requested. Regarding translations, unfortunately I don't have access to Transifex, so it seems this PR will have to wait for the next release, unless something can be done about it...

@benkonrath
Copy link
Member

Let's just push this off until the next release. I hope that's ok for you.

@benkonrath benkonrath removed this from the 1.3 milestone May 6, 2016
@benkonrath
Copy link
Member

@agustin380 I just released 1.3. Can you change the versionadded to 1.4 and rebase so that I can merge this right away. Thanks.

@benkonrath benkonrath modified the milestones: 1.3, 1.4 May 6, 2016
@scaramagus
Copy link
Contributor Author

@benkonrath Done. I suppose translations will be taken care of later?

@benkonrath
Copy link
Member

Thanks for correcting the date in the changelog. I'm not yet fully living in May it seems. :)

Merged via 4233c94.

@benkonrath benkonrath closed this May 6, 2016
@benkonrath
Copy link
Member

@agustin380 Translations are done with Transifex. You can signup and request access here:

https://www.transifex.com/django/django-localflavor/

You can ping claudep if you have an questions or run into trouble. Claude periodically syncs the translations from Transifex to this repo.

@scaramagus
Copy link
Contributor Author

@claudep Can you give me access to Transifex? I'd like to take care of the translations for this feature.

@claudep
Copy link
Member

claudep commented Jun 30, 2016

@agustin380 Did you request to be member of some team? Are you waiting for the coordinator approval? If yes, which team?

@scaramagus
Copy link
Contributor Author

@claudep I requested access to several Spanish dialects in https://www.transifex.com/django/django-localflavor/, I think they were the Argentina and Mexico ones (and neutral).

@claudep
Copy link
Member

claudep commented Jun 30, 2016

I added you to es ans es_MX. For es_AR, you should ping @ramiro who is coordinator.

@scaramagus
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants