-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MXCLABEField for Mexico #227
Conversation
4ade079
to
edc5323
Compare
b2bdd13
to
73b7969
Compare
The remaining 12 digits denote an account number, plus a verifying digit. | ||
|
||
More info: | ||
https://es.wikipedia.org/wiki/CLABE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to the English version of this wikipedia page?
Thanks for this contribution! Just those small points to fix up. I was hoping to get this into the 1.3 release which I want to release 6 or 7 May. It probably makes sense to also get the Spanish translations included with the release of this feature which means you'd need to add the translations in Transifex after this is merged. If you don't have access to Transifex , the timing won't work for the 1.3 release. |
@benkonrath Thanks for the feedback! I made the changes you requested. Regarding translations, unfortunately I don't have access to Transifex, so it seems this PR will have to wait for the next release, unless something can be done about it... |
Let's just push this off until the next release. I hope that's ok for you. |
@agustin380 I just released 1.3. Can you change the versionadded to 1.4 and rebase so that I can merge this right away. Thanks. |
@benkonrath Done. I suppose translations will be taken care of later? |
Thanks for correcting the date in the changelog. I'm not yet fully living in May it seems. :) Merged via 4233c94. |
@agustin380 Translations are done with Transifex. You can signup and request access here: https://www.transifex.com/django/django-localflavor/ You can ping claudep if you have an questions or run into trouble. Claude periodically syncs the translations from Transifex to this repo. |
@claudep Can you give me access to Transifex? I'd like to take care of the translations for this feature. |
@agustin380 Did you request to be member of some team? Are you waiting for the coordinator approval? If yes, which team? |
@claudep I requested access to several Spanish dialects in https://www.transifex.com/django/django-localflavor/, I think they were the Argentina and Mexico ones (and neutral). |
I added you to es ans es_MX. For es_AR, you should ping @ramiro who is coordinator. |
Thank you! |
This pull request adds a custom field for Clave Bancaria Estandarizada, used in all financial transactions in Mexico.
More info (in spanish):
https://es.wikipedia.org/wiki/CLABE