Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regex of BRZipCodeField #177

Closed
wants to merge 2 commits into from
Closed

Change regex of BRZipCodeField #177

wants to merge 2 commits into from

Conversation

gilsondev
Copy link

I'm change the regex to support many types of numbers:

  • 71000-000
  • 71.000-000
  • 71000000

@claudep
Copy link
Member

claudep commented Oct 27, 2015

Please remove the .po/.mo changes from the patches. Those are handled separately through Transifex.

@gilsondev
Copy link
Author

Ok

I'm change the regex to supporte many types of numbers:

 - 71000-000
 - 71.000-000
 - 71000-000
@gilsondev
Copy link
Author

Removed

@gilsondev
Copy link
Author

Now, need access the django-localflavor in Transifex. I'm send a request to come in.

@gilsondev
Copy link
Author

@claudep files removed

@claudep
Copy link
Member

claudep commented Oct 28, 2015

I'll let @avelino do the merge.

@avelino
Copy link
Member

avelino commented Oct 28, 2015

Why validate point in CEP (zipcode of Brazil)?

@gilsondev
Copy link
Author

Yes, the point in zipcode is not default to use. I go remove this.
But, the third option it's ok?

@avelino
Copy link
Member

avelino commented Oct 28, 2015

@gilsondev I think this solution is bad, if a user puts a "," for example would break their implementation.

@gilsondev
Copy link
Author

So, you think better not change the pattern?

@avelino
Copy link
Member

avelino commented Oct 28, 2015

Thinking about the use of lib, with this implementation not worth, if it is a generic implementation Yes.
Where did you get this need?

@avelino avelino closed this Oct 28, 2015
@gilsondev
Copy link
Author

I thought it would be interesting to have more than one format for zipcode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants