Add Argentinian CBU local flavor #151
Conversation
1f3b1f4 to
36662c9
Compare
|
@benkonrath Is there any problem with this pull request? It's been some time since I pushed it... |
| 'invalid': _('Enter a valid CBU in XXXXXXXXXXXXXXXXXXXXXX format.'), | ||
| 'max_length': _('CBU must be exactly 22 digits long.'), | ||
| 'min_length': _('CBU must be exactly 22 digits long.'), | ||
| 'checksum': _("Invalid CBU."), |
There was a problem hiding this comment.
Minor point: Can you change the double-quotes to single quotes for consistency?
|
@agustin380 Sorry for the delay. Thanks for the reminder. It looks good. Besides those minor points, could you also add a changelog entry. Please rebase to master and squash any changes you make into one commit. Thanks! |
0c90c16 to
f421d0a
Compare
|
@benkonrath Done, thanks for the feedback! |
| @@ -15,6 +15,8 @@ New flavors: | |||
|
|
|||
| New fields for existing flavors: | |||
|
|
|||
| - Added ARCBUField model field. | |||
There was a problem hiding this comment.
You actually added a form field, not a model field. :) Can you change this? Thanks.
There was a problem hiding this comment.
@benkonrath Damn, missed that one. It's fixed now, I hope I didn't miss anything else. Thanks again, I'll be making another PR on the following days, please stay around! ;P
This pull request adds a custom field for Clave Bancaria Uniforme, used in all financial transactions in Argentina.
More info (in spanish):
http://www.clientebancario.gov.ar/default.asp
http://es.wikipedia.org/wiki/Clave_Bancaria_Uniforme