electron build #85
Open
electron build #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendar
requested changes
Mar 27, 2017
webpack.config.babel.js
Outdated
| new webpack.DefinePlugin({ | ||
| 'process.env': { | ||
| NODE_ENV: JSON.stringify('production') | ||
| } |
There was a problem hiding this comment.
we already have env('production', [... that do the same thing
| { | ||
| "name": "Denis Podlesniy", | ||
| "email": "denis.podlesniy@djangostars.com" | ||
| }], |
| @@ -65,12 +67,7 @@ | |||
| "webpack-dev-server": "^2.3.0", | |||
| "write-file-webpack-plugin": "^3.4.2" | |||
| }, | |||
| "optionalDependencies": { | |||
| "electron": "^1.6.2" | |||
| }, | |||
There was a problem hiding this comment.
electron with all deps (electron-packager) should be in optionalDependencies
008eca3 to
f9ae48e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.