gettext issues #244
gettext issues #244
Conversation
| export default function LoginView({ handleSubmit, submitting, valid }) { | ||
| useEffect(() => { | ||
| notification.success({ | ||
| description: gettext('message description'), |
There was a problem hiding this comment.
gettext will be executed in another context here
There was a problem hiding this comment.
this is not a case... Notification will render React Component
| <button disabled={submitting || !valid }>{gettext('Login')}</button> | ||
| <span dangerouslySetInnerHTML={{ | ||
| __html: interpolate( | ||
| pgettext('EMAIL VALIDATION', 'It looks like an account with this email address already exists. Please %slog in%s to continue'), |
There was a problem hiding this comment.
pgettext used to get string for context and should be normally used inside interpolate
| <TextField name="password" label={gettext('Password')} type="password" /> | ||
| <button disabled={submitting || !valid }>{gettext('Login')}</button> | ||
| <span dangerouslySetInnerHTML={{ | ||
| __html: interpolate( |
There was a problem hiding this comment.
sometimes we need to add html into interpolate. we need to suggest another solution for such cases
There was a problem hiding this comment.
const { gettext } = useTranslations()
There was a problem hiding this comment.
we have HOC + HOOK + render prop + global function
https://django-stars.github.io/frontend-docs/docs/i18n/i18n_about#withtranslations-hoc
https://django-stars.github.io/frontend-docs/docs/i18n/i18n_about#usetranslations-hook
https://django-stars.github.io/frontend-docs/docs/i18n/i18n_about#translator-render-props
There was a problem hiding this comment.
same example as dangerouslySetInnerHTML we can use for placeholder, alert, promt...
No description provided.