Queryset pagination order and verbosity

[DannyAziz]

Added .order_by('id') as was getting inconsistent results after rebuilding the index as shown in #151

Verbosity isn't important but I liked the feature in 'django-haystack'

[DannyAziz]

@crazyscientist Are there any other changes that I should make? I would love to see this merged

[crazyscientist]

@DannyAziz To me the PR looks good now, but I have no permission to merge/accept.

@sabricot What do you think?

[ntcong]

@safwanrahman can you take a look at this? order_by is really important when you have a big dataset. Adding order_by can be a good immediate step before a better approach, like #102

[safwanrahman]

If the pk is not incremental integer, will this work? I have doubt that in the case the primary key is not integer, like uuid, it will work actually!

[safwanrahman]

@DannyAziz Can you rebase it upon master so its possible to merge?

[safwanrahman]

Thanks @ntcong for mentioning me here

[DannyAziz]

@safwanrahman I will rebase soon 👍

If you look at these 2 lines in my fork in this file: django_elasticsearch_dsl/documents.py

primary_key_field_name = self._doc_type.model._meta.pk.name
return self._doc_type.model._default_manager.all().order_by(primary_key_field_name)

It gets the name of the primary key for that model instead of assuming you are using PK, I am using UUID's in my project and it works fine

[DannyAziz]

@safwanrahman I've rebased the fork to master would love to see this merged 👍

[DannyAziz]

My bad this needs some fixing, hold on...

[safwanrahman]

This looks good. r+ from my end

[safwanrahman]

Awesome work. @DannyAziz