Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing icons in 'static()' calls #785

Merged
merged 6 commits into from
Apr 1, 2016
Merged

Missing icons in 'static()' calls #785

merged 6 commits into from
Apr 1, 2016

Conversation

mikek
Copy link
Contributor

@mikek mikek commented Mar 30, 2016

Add missing icons and use safer static() calls in IconsMixin.

See code comments and #438 for details.

  • IconsMIxin: workaround for static() call on possibly non-existent file
  • Add test cases for missing files in static() calls
  • Revert "remove 16x16px icon size
  • Add all missing icons in static/filer/icons for sizes of 16/32/48/64px

@mikek
Copy link
Contributor Author

mikek commented Mar 30, 2016

@lory87, please add missing icons. Feel free to ping me if you need any further info.

@cyberstar
Copy link

LGTM

@intellectronica
Copy link
Contributor

👍

@vxsx
Copy link
Contributor

vxsx commented Apr 1, 2016

FE 👍

@lory87 lory87 assigned mikek and unassigned lory87 Apr 1, 2016
@mikek mikek merged commit 0254372 into develop Apr 1, 2016
@mikek mikek mentioned this pull request Apr 1, 2016
Closed
@mikek mikek deleted the issue/static-call-on-missing-icons branch April 13, 2016 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikek mikek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikek @cyberstar @intellectronica @vxsx @lory87