Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nits and stuff #3542

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented Aug 30, 2023

This PR is a small collection of tiny fixes for things which I've hit in various contexts:

  • run-server-func-tests contains a couple of definitions which appear to be unused.
  • datasets_inventory.py contains a docstring which was missed when I reworked tar file extraction.
  • The regex in the Agent container Makefile used to extract the version number from the RPM file name doesn't work properly if the "revision" number is missing (it requires the second dot which would be omitted when the third number is omitted).

The last issue was causing some misbehavior in the b0.73 branch build (but Nick is going to fix that by adding the "revision" number).

@webbnh webbnh merged commit d6ea9d0 into distributed-system-analysis:main Aug 31, 2023
@webbnh webbnh deleted the nits_and_stuff branch August 31, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants