Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the issues that we've seen recently with the Dashboard unit testing in the CI.
In particular, the unit tests were failing with
which was the result of a breaking change to the
tough-cookie
component.tough-cookie
is not used by the Dashboard; rather, it's a dependency of a dependency of Jest which we use for Dashboard unit testing.This PR makes three changes:
tough-cookie
v4.1.2 (the breakage was introduced in v4.1.0, and v4.1.1 was a failed attempt to fix it); without the explicit dependency, we seem to still pick up v4.1.0.node_modules
directory, to ensure that we pick up a fresh installation of our dependencies. (There are other ways to accomplish this (such as thenpm
commands,clean-install
andci
), but without a version-controlledpackage-lock.json
file, they all present problems, so we'll just brute-force it for now.) Also, since it's not currently version-controlled, remove thepackage-lock.json
file, so that we generate a fresh set of dependencies on each build.nvm
. It pulls a very old version of the manager, and we don't seem to actually need it (at least, as a production dependency...).