Do not use the file logger at all in python commands.

The logger only uses the default Streamhandler now which outputs to stderr.

agent/config/pbench-agent-default.cfg

@@ -9,12 +9,6 @@ pbench_log = %(pbench_run)s/pbench.log
 # RPM requirement mode: strict vs relaxed
 rpm_requirement_mode = strict
 
-[logging]
-logger_type = file
-# # "log_dir" is only considered when "logger_type" is set to "file"; And by
-# # default the log file directory is the "pbench_run" directory.
-# log_dir =
-
 [results]
 user = pbench
 host_info_uri = pbench-results-host-info.versioned/pbench-results-host-info.URL002

lib/pbench/agent/__init__.py

@@ -61,13 +61,6 @@ def __init__(self, cfg_name):
             )
             self.pbench_lib_dir = self.pbench_install_dir / "lib"
 
-        if self.logger_type == "file" and self.log_dir is None:
-            # The configuration file has a logging section configured to use
-            # "file" logging, but no log directory is set.  We'll set the log
-            # directory to be the directory of the legacy ${pbench_log} value
-            # determined above.
-            self.log_dir = str(self.pbench_log.parent)
-
         try:
             self.ssh_opts = self.get("results", "ssh_opts", fallback=DEFAULT_SSH_OPTS)
         except (NoOptionError, NoSectionError):

lib/pbench/agent/base.py

@@ -54,11 +54,6 @@ def __init__(self, context):
             )
             click.get_current_context().exit(1)
 
-        # log file - N.B. not a directory
-        self.pbench_log = self.config.pbench_log
-        if self.pbench_log is None:
-            self.pbench_log = self.pbench_run / "pbench.log"
-
         self.pbench_install_dir = self.config.pbench_install_dir
         if self.pbench_install_dir is None:
             self.pbench_install_dir = "/opt/pbench-agent"
@@ -71,7 +66,7 @@ def __init__(self, context):
         self.pbench_bspp_dir = self.pbench_install_dir / "bench-scripts" / "postprocess"
         self.pbench_lib_dir = self.pbench_install_dir / "lib"
 
-        self.logger = setup_logging(debug=False, logfile=self.pbench_log)
+        self.logger = setup_logging(debug=False, logfile=None)
 
         self.ssh_opts = os.environ.get("ssh_opts", self.config.ssh_opts)
         self.scp_opts = os.environ.get("scp_opts", self.config.scp_opts)