Don't test ./examples by default #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
make testchecks types withmypy, then runs tests found in the./testsdirectory. At the moment we symlink./examplesas./test/examplesso that we test the examples when runningmake test.Given that our build matrix is growing (#136, #140, #143), we may run into a situation where the examples hit rate limits when run for each Python version, causing CI to fail. For this reason, I've removed the symlink so that we don't test examples by default.
I've added a new make command that tests the examples. We can run this locally as necessary. To ensure we at least have some coverage, I've added a single CI run that will test the examples using Python 3.12 only.