update readme, fix issues

README.md

@@ -1,8 +1,62 @@
 # Embargoes
-Drupal 8 module for managing embargo policies with access restrictions on content
+
+# Introduction
+
+Adds the ability to manage embargo policies with access restrictions on content.
 
 ## Requirements
-Embargoes requires no other Drupal modules to work.
+
+This module requires the following modules/libraries:
+
+* [Menu UI](https://www.drupal.org/docs/core-modules-and-themes/core-modules/menu-ui-module)
+
+## Installation
+
+Install as
+[usual](https://www.drupal.org/docs/8/extending-drupal-8/installing-drupal-8-modules).
+
+## Configuration
+
+Configuration options can be set at `admin/config/content/embargoes/settings`,
+including notification options and IP range settings that can apply to
+embargoes.
+
+To add an IP range for use on embargoes, navigate to
+`admin/config/content/embargoes/settings/ips` and click 'Add IP range'. Ranges
+created via this method can then be used as IP address whitelists when creating
+embargoes.
+
+## Usage
+
+### Applying an embargo
+
+An embargo can be applied to an existing node by navigating to
+`node/{node_id/embargoes`. From here, an embargo can be applied if it doesn't
+already exist, and existing embargoes can be modified or removed.
+
+### Logging
+
+Embargo logs are kept at `admin/config/content/embargoes/settings/log`,
+including who created the embargo, or how it was changed.
+
+## Troubleshooting/Issues
+
+Having problems or solved one? Contact
+[discoverygarden](http://support.discoverygarden.ca).
+
+## Maintainers/Sponsors
+
+Current maintainers:
+
+* [discoverygarden](http://www.discoverygarden.ca)
+
+## Development
+
+If you would like to contribute to this module, please check out the helpful
+[Documentation](https://github.com/Islandora/islandora/wiki#wiki-documentation-for-developers),
+[Developers](http://islandora.ca/developers) section on Islandora.ca and create
+an issue, pull request and or contact
+[discoverygarden](http://support.discoverygarden.ca).
 
 ## License
 [GPLv2](http://www.gnu.org/licenses/gpl-2.0.txt)

src/Controller/EmbargoesLogController.php

@@ -12,7 +12,11 @@ class EmbargoesLogController extends ControllerBase {
 
   public function showRenderedLog() {
     $database = \Drupal::database();
-    $result = $database->query('SELECT * FROM {embargoes_log} ORDER BY time DESC;');
+    $result = $database->getConnection()
+      ->select('embargoes_log', 'el')
+      ->fields('el')
+      ->orderBy('el.time', 'DESC')
+      ->execute();
 
     $formatted_log = [];
     foreach ($result as $record) {

src/Form/EmbargoesIpRangeEntityForm.php

@@ -33,6 +33,7 @@ public function form(array $form, FormStateInterface $form_state) {
       '#default_value' => $range->label(),
       '#description' => $this->t("Label for the IP range."),
       '#required' => TRUE,
+      '#id' => 'ip-range-label',
     ];
 
     $form['range'] = [