Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-compound compound displays #15

Merged
merged 7 commits into from
Feb 3, 2023
Merged

non-compound compound displays #15

merged 7 commits into from
Feb 3, 2023

Conversation

JojoVes
Copy link
Contributor

@JojoVes JojoVes commented Jan 26, 2023

  • Only scratching the surface of potentially useful functionality.
  • Trying to be as unobtrusive as possible while allowing non-compound objects with child nodes and media to display as if they were Compound Objects that are the first member of their set. (Replicating a presentation that was available in i7)

Got things configured to a functional state, so committing what I have so far.
Some logic still needs to be cleaned up, and I think the new Condition should
probably go in a more general use space like dgi_i8_helper or right up to core
Islandora, but committing anyway 'cause I don't want to risk losing this progress.
only show nodes as members of themselves if they have children, media, and the site has been configured to allow it.
@JojoVes JojoVes changed the title [WIP] non-compound compound displays non-compound compound displays Jan 27, 2023
@JojoVes JojoVes marked this pull request as ready for review January 27, 2023 21:21
@nchiasson-dgi nchiasson-dgi added the minor Added functionality that is backwards compatible. label Feb 2, 2023
@nchiasson-dgi nchiasson-dgi merged commit f30590a into 1.x Feb 3, 2023
@willtp87 willtp87 deleted the 1.x-parent-is-member branch September 26, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Added functionality that is backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants