Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update eslint version and config #62

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

davidtaylorhq
Copy link
Member

No description provided.

@davidtaylorhq davidtaylorhq merged commit fedbb86 into main Nov 18, 2024
3 checks passed
@davidtaylorhq davidtaylorhq deleted the eslint-upgrade branch November 18, 2024 12:24
@pfaffman
Copy link

I updated my existing plugin like this:

rm -f .eslintrc.cjs yarn.lock 
cp ~/src/discourse-repos/discourse-plugin-skeleton/.npmrc  ~/src/discourse-repos/discourse-plugin-skeleton/eslint.config.mjs ~/src/discourse-repos/discourse-plugin-skeleton/package.json ~/src/discourse-repos/discourse-plugin-skeleton/pnpm-lock.yaml .

Now when I do

pnpm eslint --fix --no-error-on-unmatched-pattern {test,assets}/javascripts

all of my javascript fails like this

  1:1  error  Parsing error: The keyword 'import' is reserved

Am I doing the wrong pnp eslint command? I don't know how to find it except to see how it fails in github actions.

@davidtaylorhq
Copy link
Member Author

davidtaylorhq commented Nov 19, 2024

@pfaffman are you sure everything was copied correctly, and the old config file was deleted? Could you link me to a branch of a broken plugin?

(feel free to drop me a message on Meta if it's easier)

@pfaffman
Copy link

Sorry. The missing step was pnpm install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants