Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "opus/silk/arm/NSQ_neon.c" to the "target_arch==\"arm64\"" condit… #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

deepso7
Copy link

@deepso7 deepso7 commented Dec 3, 2024

## Description

Fixes dyld: missing symbol called on macOS and apple silicon
as reported in #165

@krische
Copy link
Contributor

krische commented Feb 10, 2025

@vladfrangu Can this get reviewed and merged?

@vladfrangu
Copy link
Member

Is this needed? I've been able to use it on macos M1 without this 👀

@krische
Copy link
Contributor

krische commented Feb 11, 2025

Is this needed? I've been able to use it on macos M1 without this 👀

Interesting, I'm targeting linux/arm64/v8 container platform in my GitHub build and it's failing to compile opus inside it for I believe the error this PR fixes. I'll have to try and isolate it further to reproduce.

@vladfrangu
Copy link
Member

If you can get us a repro dockerfile or such that'd be lovely too! Including the JS code to test locally 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants