-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add animated banner guild feature #6812
Conversation
23e0efa
to
b7fc04a
Compare
/** | ||
* The URL to this guild's banner. | ||
* @param {ImageURLOptions} [options={}] Options for the Image URL | ||
* @returns {?string} | ||
*/ | ||
bannerURL({ format, size, dynamic } = {}) { | ||
return this.banner && this.client.rest.cdn.Banner(this.id, this.banner, format, size, dynamic); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should instead be modified in the AnonymousGuild
class:
discord.js/packages/discord.js/src/structures/AnonymousGuild.js
Lines 69 to 76 in ed0cfd9
/** | |
* The URL to this guild's banner. | |
* @param {StaticImageURLOptions} [options={}] Options for the Image URL | |
* @returns {?string} | |
*/ | |
bannerURL({ format, size } = {}) { | |
return this.banner && this.client.rest.cdn.Banner(this.id, this.banner, format, size); | |
} |
Both an InviteGuild
and a Guild
can receive the animated hash.
Upstream got merged. Are you able to continue, @iShibi? |
it's been a long gap, you can takeover if it's fine with you |
I've looked over what needs to be done to support animated guild banners in discord.js. For some reason, the discord.js/packages/discord.js/src/structures/AnonymousGuild.js Lines 78 to 85 in 402514f
All that's left is to bump discord-api-types to 0.31.0 so the typings are updated for the new guild feature. However, this is already being done in #7634, so it looks like no pull request is needed for this and support will naturally come! |
See comment above ^ |
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: