Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(InteractionReplyOptions): Add withResponse #10637

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Dec 5, 2024

Please describe the changes this PR makes and why it should be merged:
Missed with #10499. Tests passed because the overloads intersected with the property being present, but the property is not actually present on the interface itself.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 8:40am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 8:40am

@kodiakhq kodiakhq bot merged commit 231954d into main Dec 9, 2024
25 checks passed
@kodiakhq kodiakhq bot deleted the types/with-response-reply-options branch December 9, 2024 08:44
imnaiyar pushed a commit to imnaiyar/discord.js that referenced this pull request Dec 9, 2024
types(InteractionReplyOptions): add `withResponse`

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants