Adds TypeScript type declarations #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @discordier, assuming there isn't much other upcoming activity for this repo, would you be fine with merging the PR as-is? (I'm not able to merge AFAIK) |
|
Hi simon, Thanks for your contribution, it has been released as 0.2.1 and pushed to npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to see if this could be auto-generated using https://www.typescriptlang.org/tsconfig#emitDeclarationOnly. But it seems that TypeScript has had a long-standing open issue (microsoft/TypeScript#15416) about supporting files not ending in
JS/JSX/TS/TSX.Thoughts on adding this? I wasn't sure if this would need any changes to
build/build.js, but probably not?If we don't add it here, I would be happy to instead submit a PR to https://github.com/DefinitelyTyped/DefinitelyTyped.