Implement proper parser for the REPL #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61300af to
8dc453f
Compare
Mnpn
approved these changes
Aug 12, 2019
|
Great, thank you very much! |
tbodt
reviewed
Aug 12, 2019
| # This will not work for you. | ||
| # pls ignore. | ||
| cd "$GOPATH/bin" | ||
| ./Cross\ Compile.sh DiscordConsole discordconsole-team |
There was a problem hiding this comment.
I don't have access to the script anymore, but I suppose @Mnpn03 could check it in (although IIRC it largely assumes a bunch of structure)
There was a problem hiding this comment.
Can someone please remind me about this later, thanks!
There was a problem hiding this comment.
@Mnpn03 Do you know what happened with the guy who invented the door-knocker?
There was a problem hiding this comment.
He won the no-bell price.
There was a problem hiding this comment.
🔔 Anyway, this is your friendly reminder to commit the script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely a breaking change. New syntax:
cmd Arg1 "Argument 2" Arg3 Argument\ 4, similar to bash\nis now a line break, and can be escaped with\\n${...}is now used for substitutions, and can be escaped with\${...}.This also proposes using Just instead of GNU Make so @tbodt doesn't have to feel bad about us abusing the almighty Make by treating it as a simple command runner.