3.1.3 discord 1 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
955e447 to
e3ff091
Compare
mrkcsc
commented
Nov 25, 2021
| fun ignoreAutoRotate(ignoreAutoRotate: Boolean) { | ||
| this.autoRotateIgnored = ignoreAutoRotate | ||
| this.maybeLockToPortrait() | ||
| } |
There was a problem hiding this comment.
New API surface to disable the default behavior of respecting the auto-rotate setting.
mrkcsc
commented
Nov 25, 2021
| private const val INTENT_VALUE_KEY = "newConfig" | ||
|
|
||
| @Suppress("unused") | ||
| fun sendBroadcast(activity: Activity, newConfig: Configuration) { |
There was a problem hiding this comment.
New config method caller can use to report configuration that does not leak magic strings.
mrkcsc
commented
Nov 25, 2021
| import com.facebook.react.bridge.LifecycleEventListener | ||
| import com.facebook.react.bridge.ReactContext | ||
|
|
||
| internal class OrientationAutoRotateListener( |
There was a problem hiding this comment.
Observer for when the auto rotate setting is toggled.
* Android - Emit orientation change event on host resume * Cleanup code, PR feedback * Only allow PORTRAIT and LANDSCAPE when receiving rotation event * Unify logic in OrientationConfigListener
6e133ba to
1f85c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin.ignoreAutoRotate).OrientationConfigListener.sendBroadcast).Our
package.jsonis pointing to the latest commit at: e3ff091