change file naming strategy #7415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckohen
reviewed
Mar 9, 2025
| @@ -106,7 +106,7 @@ const validLinks = new Map<string, string[]>([ | |||
| // Gather valid links | |||
| const changelogAnchors = []; | |||
| for (const [name, raw] of docFiles) { | |||
| const keyName = `DOCS${name.replaceAll("/", "_").toUpperCase()}`; | |||
| const keyName = `DOCS${name.replaceAll("/", "_").replaceAll("-", "_").toUpperCase()}`; | |||
There was a problem hiding this comment.
Suggested change
| const keyName = `DOCS${name.replaceAll("/", "_").replaceAll("-", "_").toUpperCase()}`; | |
| const keyName = `DOCS${name.replaceAll(/[/-]/g ,"_").toUpperCase()}`; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us away from capital letters and underscores in files, and towards lower case and dashes. The corresponding dev portal PR also stops trying to infer the title of the doc from the filename, and instead uses the title metadata or H1 contents.